chore: blocknumber setup #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GRT-37 Package scaffolding
AC:
|
0xkenj1
requested changes
Jul 18, 2024
packages/blocknumber/.gitignore
Outdated
There was a problem hiding this comment.
We can add this on the root .gitignore with a wildcard to avoid having a gitignore per package
packages/blocknumber/.prettierignore
Outdated
There was a problem hiding this comment.
ditto,
pnpm-lock.yaml shouldn't be generated on pnpm install i think
| "name": "blocknumber", | ||
| "version": "1.0.0", | ||
| "description": "", | ||
| "main": "index.ts", |
There was a problem hiding this comment.
lets add "type": "module" to ensure we are using esm
| "outDir": "dist" | ||
| }, | ||
| "include": ["src/**/*"], | ||
| "exclude": ["**/*.spec.ts"] |
There was a problem hiding this comment.
Suggested change
| "exclude": ["**/*.spec.ts"] | |
| "exclude": ["node_modules", "build", "tests", "vitest.config.ts"] |
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "extends": "../../tsconfig.build.json", | |||
| "compilerOptions": { | |||
There was a problem hiding this comment.
Suggested change
| "compilerOptions": { | |
| "compilerOptions": { | |
| "declaration": true, |
0xnigir1
reviewed
Jul 19, 2024
| @@ -4,11 +4,13 @@ | |||
| "description": "", | |||
| "main": "index.js", | |||
| "scripts": { | |||
| "build": "turbo run build", | |||
| "test": "turbo run test", | |||
There was a problem hiding this comment.
we can add the test coverage script here too
packages/blocknumber/package.json
Outdated
| "lint:fix": "pnpm lint --fix", | ||
| "format": "prettier --check .", | ||
| "format:fix": "prettier --write .", | ||
| "test": "vitest run" |
There was a problem hiding this comment.
ditto regarding test coverage
0xnigir1
approved these changes
Jul 22, 2024
0xkenj1
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-37
Description
Set up
blocknumberpackage with scripts, integration with monorepo and testing framework.