-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do Not Publish Pre-Release Builds in Official Releases in Nuget #236
Do Not Publish Pre-Release Builds in Official Releases in Nuget #236
Conversation
WalkthroughThe Continuous Deployment (CD) workflows have been refined to enhance their activation criteria. Now, in addition to the previously recognized "-dev" tags, these workflows are also responsive to pushes to certain branches and tags that conclude with "-alpha", "-beta", or "-rc". This expansion broadens the scope of deployment scenarios, catering to various stages of release cycles. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (2)
- .github/workflows/CD-dev.yml (1 hunks)
- .github/workflows/CD.yml (1 hunks)
Additional comments: 2
.github/workflows/CD.yml (1)
- 6-8: The trigger conditions for branches and tags have been updated. Ensure that the negation pattern for branches (
"!not_activated_on_branches!*"
) and the semantic versioning pattern for tags ("[0-9]+.[0-9]+.[0-9]+"
) correctly align with the project's branching and versioning strategy. This setup will exclude branches matching the negation pattern and trigger on tags that follow semantic versioning..github/workflows/CD-dev.yml (1)
- 9-11: The addition of tag patterns for "-alpha", "-beta", and "-rc" versions aligns with the PR objectives to handle pre-release versions separately. Ensure that these patterns (
"[0-9]+.[0-9]+.[0-9]+-alpha.[0-9]+"
,"[0-9]+.[0-9]+.[0-9]+-beta.[0-9]+"
,"[0-9]+.[0-9]+.[0-9]+-rc.[0-9]+"
) correctly match the project's versioning scheme for pre-release versions. This setup allows for the automated handling of different types of pre-release versions, directing them to the intended NuGet repository for unstable builds.
Just like the title says.... When I released
4.0.0-alpha.1
on GitHub, this pushed the build into:https://www.nuget.org/packages/Deepgram/
We should not put pre-release builds there. Rather we should put them into the new unstable release package:
https://www.nuget.org/packages/Deepgram.Unstable.SDK.Builds/
Summary by CodeRabbit