Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do Not Publish Pre-Release Builds in Official Releases in Nuget #236

Merged

Conversation

davidvonthenen
Copy link
Contributor

@davidvonthenen davidvonthenen commented Feb 16, 2024

Just like the title says.... When I released 4.0.0-alpha.1 on GitHub, this pushed the build into:
https://www.nuget.org/packages/Deepgram/

We should not put pre-release builds there. Rather we should put them into the new unstable release package:
https://www.nuget.org/packages/Deepgram.Unstable.SDK.Builds/

Summary by CodeRabbit

  • Chores
    • Updated Continuous Deployment workflows to support new triggers for version tags including "-alpha", "-beta", "-rc", enhancing the deployment process for different stages of release.

Copy link
Contributor

coderabbitai bot commented Feb 16, 2024

Walkthrough

The Continuous Deployment (CD) workflows have been refined to enhance their activation criteria. Now, in addition to the previously recognized "-dev" tags, these workflows are also responsive to pushes to certain branches and tags that conclude with "-alpha", "-beta", or "-rc". This expansion broadens the scope of deployment scenarios, catering to various stages of release cycles.

Changes

File Path Change Summary
.github/workflows/CD-dev.yml Updated to trigger on push events to specific branches and tags, including "-alpha", "-beta", "-rc" tags.
.github/workflows/CD.yml Similar to CD-dev.yml, enhanced to support triggering on version tags ending with "-alpha", "-beta", "-rc".

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 41575c4 and fdd3213.
Files selected for processing (2)
  • .github/workflows/CD-dev.yml (1 hunks)
  • .github/workflows/CD.yml (1 hunks)
Additional comments: 2
.github/workflows/CD.yml (1)
  • 6-8: The trigger conditions for branches and tags have been updated. Ensure that the negation pattern for branches ("!not_activated_on_branches!*") and the semantic versioning pattern for tags ("[0-9]+.[0-9]+.[0-9]+") correctly align with the project's branching and versioning strategy. This setup will exclude branches matching the negation pattern and trigger on tags that follow semantic versioning.
.github/workflows/CD-dev.yml (1)
  • 9-11: The addition of tag patterns for "-alpha", "-beta", and "-rc" versions aligns with the PR objectives to handle pre-release versions separately. Ensure that these patterns ("[0-9]+.[0-9]+.[0-9]+-alpha.[0-9]+", "[0-9]+.[0-9]+.[0-9]+-beta.[0-9]+", "[0-9]+.[0-9]+.[0-9]+-rc.[0-9]+") correctly match the project's versioning scheme for pre-release versions. This setup allows for the automated handling of different types of pre-release versions, directing them to the intended NuGet repository for unstable builds.

.github/workflows/CD.yml Show resolved Hide resolved
.github/workflows/CD-dev.yml Show resolved Hide resolved
@davidvonthenen davidvonthenen merged commit 1968db0 into deepgram:main Feb 16, 2024
4 checks passed
@davidvonthenen davidvonthenen deleted the sort-placement-of-packages branch February 16, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants