-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit of OnPrem Model Classes #216
Conversation
WalkthroughThe recent updates to the Deepgram .NET SDK involve modifications to project metadata, enhancements to model flexibility by allowing nullable properties, and the introduction of new properties and documentation comments in the OnPrem models. These changes aim to improve the SDK's usability and adaptability, particularly in handling optional data and extending support for on-premises deployment configurations. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files selected for processing (6)
- Deepgram/Deepgram.csproj (2 hunks)
- Deepgram/Models/Authenticate/v1/DeepgramClientOptions.cs (1 hunks)
- Deepgram/Models/OnPrem/v1/CredentialResponse.cs (1 hunks)
- Deepgram/Models/OnPrem/v1/CredentialsResponse.cs (1 hunks)
- Deepgram/Models/OnPrem/v1/DistributionCredentials.cs (1 hunks)
- Deepgram/Models/OnPrem/v1/Member.cs (1 hunks)
Additional comments: 3
Deepgram/Models/Authenticate/v1/DeepgramClientOptions.cs (1)
- 19-24: LGTM! Making
BaseAddress
andAPIVersion
nullable increases the SDK's flexibility.Deepgram/Models/OnPrem/v1/DistributionCredentials.cs (1)
- 23-33: LGTM! Making
Scopes
nullable and changingCreated
toDateTime
improves the SDK's robustness and functionality.Deepgram/Deepgram.csproj (1)
- 13-18: LGTM! The updates to the project metadata, including the company name, authors, and title, are correctly implemented.
Based on documentation on public website:
https://developers.deepgram.com/reference/list-credentials
Unit Tests:
Will fix all
TODOs
later.Summary by CodeRabbit
New Features
Documentation
Refactor