Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit of OnPrem Model Classes #216

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

davidvonthenen
Copy link
Contributor

@davidvonthenen davidvonthenen commented Feb 6, 2024

Based on documentation on public website:
https://developers.deepgram.com/reference/list-credentials

Unit Tests:
Screenshot 2024-02-06 at 11 08 30

Will fix all TODOs later.

Summary by CodeRabbit

  • New Features

    • Introduced the ability for certain model properties to accept null values, enhancing flexibility in data handling.
    • Added new properties to improve authentication and credential management.
  • Documentation

    • Updated metadata in the project file including company name, authors, and title.
    • Added documentation comments for clearer understanding of new properties.
  • Refactor

    • Modified property types in several models to support nullable values and adjusted date handling for better consistency.

Copy link
Contributor

coderabbitai bot commented Feb 6, 2024

Walkthrough

The recent updates to the Deepgram .NET SDK involve modifications to project metadata, enhancements to model flexibility by allowing nullable properties, and the introduction of new properties and documentation comments in the OnPrem models. These changes aim to improve the SDK's usability and adaptability, particularly in handling optional data and extending support for on-premises deployment configurations.

Changes

File Path Change Summary
Deepgram/Deepgram.csproj Updated project metadata including company name, authors, and title.
Deepgram/Models/Authenticate/v1/... Made BaseAddress and APIVersion properties nullable.
Deepgram/Models/OnPrem/v1/CredentialResponse.cs Added Member and DistributionCredentials properties with JSON naming.
Deepgram/Models/OnPrem/v1/CredentialsResponse.cs Made DistributionCredentials nullable and added documentation for it.
Deepgram/Models/OnPrem/v1/DistributionCredentials.cs Changed Scopes to nullable and Created to DateTime.
Deepgram/Models/OnPrem/v1/Member.cs Added documentation comments for MemberId and Email.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 3

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 785c101 and 077384e.
Files selected for processing (6)
  • Deepgram/Deepgram.csproj (2 hunks)
  • Deepgram/Models/Authenticate/v1/DeepgramClientOptions.cs (1 hunks)
  • Deepgram/Models/OnPrem/v1/CredentialResponse.cs (1 hunks)
  • Deepgram/Models/OnPrem/v1/CredentialsResponse.cs (1 hunks)
  • Deepgram/Models/OnPrem/v1/DistributionCredentials.cs (1 hunks)
  • Deepgram/Models/OnPrem/v1/Member.cs (1 hunks)
Additional comments: 3
Deepgram/Models/Authenticate/v1/DeepgramClientOptions.cs (1)
  • 19-24: LGTM! Making BaseAddress and APIVersion nullable increases the SDK's flexibility.
Deepgram/Models/OnPrem/v1/DistributionCredentials.cs (1)
  • 23-33: LGTM! Making Scopes nullable and changing Created to DateTime improves the SDK's robustness and functionality.
Deepgram/Deepgram.csproj (1)
  • 13-18: LGTM! The updates to the project metadata, including the company name, authors, and title, are correctly implemented.

Deepgram/Models/OnPrem/v1/Member.cs Show resolved Hide resolved
@CopperBeardy CopperBeardy merged commit 3fb47cb into deepgram:main Feb 7, 2024
4 checks passed
@davidvonthenen davidvonthenen deleted the audit-onprem-model branch February 8, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants