Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit of Manage Model Classes #206

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Audit of Manage Model Classes #206

merged 1 commit into from
Feb 5, 2024

Conversation

davidvonthenen
Copy link
Contributor

This modifies the Manage classes based on the audit document.

Using Go as a reference:
https://github.com/deepgram/deepgram-go-sdk/blob/main/pkg/api/manage/v1/interfaces/types.go

Passed unit tests:
Screenshot 2024-02-04 at 14 33 27

@davidvonthenen
Copy link
Contributor Author

Will fix the TODO documentation notes later.

@davidvonthenen davidvonthenen merged commit d763338 into deepgram:main Feb 5, 2024
4 checks passed
@davidvonthenen davidvonthenen deleted the audit-manage-model branch February 5, 2024 16:27
@davidvonthenen davidvonthenen mentioned this pull request Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeocodes lukeocodes lukeocodes approved these changes

@jpvajda jpvajda Awaiting requested review from jpvajda

@SandraRodgers SandraRodgers Awaiting requested review from SandraRodgers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidvonthenen @lukeocodes