Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GLB curator #38

Merged
merged 20 commits into from
Feb 23, 2024
Merged

fix: GLB curator #38

merged 20 commits into from
Feb 23, 2024

Conversation

dalkia
Copy link
Collaborator

@dalkia dalkia commented Feb 15, 2024

  • Scene Content correction. The scene content map was not returning correct values to due to inconsistencies in the caps locs
  • Quaternion: Some rotations were in euler angles in the manifest. This caused weird artifacts due to invalid Matrix4x4,
  • PiXYZ rotation fix: Rotation into the PiXYZ world was not being done correctly
  • New GLB importer: MAJOR change. A curation to all GLBs is done before importing into PiXYZ using SharpGLTF. This solves the alphaMode being ignored; flatten the hierarchy of all meshes so only one material and one mesh is present per node; allowing a better merge result with no nodes being ignored.
  • Missing bin for certain glbs: Bin were being filtered out when downloading content
  • Ignore conversion if the parcel is a road

@dalkia dalkia changed the title fix: Scene Content and Quaternion fix fix: Several fixes Feb 20, 2024
@dalkia dalkia changed the title fix: Several fixes fix: GLB curator Feb 20, 2024
@dalkia dalkia force-pushed the fix/generation-issues branch from 1ddfe51 to 19962e2 Compare February 22, 2024 14:39
@dalkia dalkia merged commit ae8a698 into main Feb 23, 2024
2 checks passed
@dalkia dalkia deleted the fix/generation-issues branch February 23, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants