Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Texture tweens #279

Merged
merged 8 commits into from
Jan 13, 2025
Merged

Texture tweens #279

merged 8 commits into from
Jan 13, 2025

Conversation

nearnshaw
Copy link
Member

No description provided.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 2, 2024 •
edited
Loading

Deploying adr with  Cloudflare Pages  Cloudflare Pages

Latest commit: e861a07
Status: ✅  Deploy successful!
Preview URL: https://693f172f.adr-cvq.pages.dev
Branch Preview URL: https://texture-tweens.adr-cvq.pages.dev

View logs

aixaCode
aixaCode reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@aixaCode aixaCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, but looks good

content/ADR-253-light-sources.md Outdated Show resolved Hide resolved
content/ADR-255-texture-tweens.md Outdated Show resolved Hide resolved
content/ADR-255-texture-tweens.md Show resolved Hide resolved
leanmendoza
leanmendoza requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@leanmendoza leanmendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the ADR itself is okay and is clear documentation of the already implemented texture tweening, we lack the dependency Tween

@AlejandroAlvarezMelucciDCL
Update ADR-255-texture-tweens.md
13d5e83 
Added serialization definitions for Tween and Texture

Signed-off-by: Alejandro Alvarez Melucci <[email protected]>
@nearnshaw
Copy link
Member Author

Although the ADR itself is okay and is clear documentation of the already implemented texture tweening, we lack the dependency Tween

@leanmendoza I believe the separate ADR for the Tween component is beyond the scope of this PR. I think we're all reasonably on the same page about this ADR, and should be good to merge it.

Please remove the change request so GH lets me merge it.

@nearnshaw nearnshaw marked this pull request as ready for review January 9, 2025 16:36
@nearnshaw nearnshaw requested a review from a team as a code owner January 9, 2025 16:36
@nearnshaw nearnshaw requested a review from mikhail-dcl January 9, 2025 16:36
@nearnshaw nearnshaw merged commit 45db495 into main Jan 13, 2025
2 checks passed
@nearnshaw nearnshaw deleted the texture-tweens branch January 13, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leanmendoza leanmendoza leanmendoza approved these changes

@aixaCode aixaCode aixaCode approved these changes

@mikhail-dcl mikhail-dcl Awaiting requested review from mikhail-dcl mikhail-dcl is a code owner automatically assigned from decentraland/adr-editors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nearnshaw @aixaCode @leanmendoza @AlejandroAlvarezMelucciDCL