Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter] Use Go SDK to list clusters #4385

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Jan 9, 2025

Changes

This helps us with the following:

  • use paginated output that is more efficient
  • automatically filter non-interactive clusters instead of doing it ourselves

P.S. We still have usage of 2.0 API coming from mounts and some other places

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

This helps us with the following:

- use paginated output that is more efficient
- automatically filter non-interactive clusters instead of doing it ourselves

P.S. We still have usage of 2.0 API coming from mounts and some other places
@alexott alexott requested review from a team as code owners January 9, 2025 11:46
@alexott alexott requested review from renaudhartert-db and removed request for a team January 9, 2025 11:46
@alexott alexott temporarily deployed to test-trigger-is January 9, 2025 11:46 — with GitHub Actions Inactive
Copy link

github-actions bot commented Jan 9, 2025

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4385
  • Commit SHA: 296f6003e992a47a114b71bece0db3c6e73b9156

Checks will be approved automatically on success.

@alexott alexott temporarily deployed to test-trigger-is January 9, 2025 11:47 — with GitHub Actions Inactive
@alexott alexott added the exporter TF configuration generator label Jan 10, 2025
@renaudhartert-db renaudhartert-db requested review from rauchy and removed request for renaudhartert-db January 10, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter TF configuration generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant