Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Add description of clean_rooms_notebook_task in databricks_job #4368

Merged
merged 1 commit into from
Jan 7, 2025
Merged

[Doc] Add description of clean_rooms_notebook_task in databricks_job #4368

merged 1 commit into from
Jan 7, 2025

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Jan 2, 2025

Changes

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@alexott alexott requested review from a team as code owners January 2, 2025 13:24
@alexott alexott requested review from parthban-db and removed request for a team January 2, 2025 13:24
@alexott alexott temporarily deployed to test-trigger-is January 2, 2025 13:24 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4368
  • Commit SHA: 5c59cd9ce7c4bcc0c0d497bffa872be292119b72

Checks will be approved automatically on success.

@alexott alexott temporarily deployed to test-trigger-is January 2, 2025 13:24 — with GitHub Actions Inactive
@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/12583139624

@alexott alexott added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit ae85efb Jan 7, 2025
12 checks passed
@alexott alexott deleted the doc/clean_rooms_notebook_task branch January 7, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyucht mgyucht mgyucht approved these changes

@parthban-db parthban-db Awaiting requested review from parthban-db parthban-db is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexott @eng-dev-ecosystem-bot @mgyucht