[Internal] Retry on 504 when calling the permission API #4355
+144
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rauchy
approved these changes
Dec 27, 2024
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
|
Test Details: go/deco-tests/12518392447 |
Agreed, done. |
renaudhartert-db
requested review from
parthban-db
and removed request for
a team
renaudhartert-db
added a commit
that referenced
this pull request
Dec 30, 2024
### Bug Fixes * Reflect backend updates in state for databricks_app ([#4337](#4337)). ### Documentation * Update `databricks_workspace_conf` documentation ([#4334](#4334)). * apply `make fmt-docs` to all docs ([#4344](#4344)). ### Internal Changes * Generate both SdkV2-compatible and Plugin Framework-compatible structures ([#4332](#4332)). * Mark TestAccServicePrincipalResourceOnAzure test as flaky ([#4333](#4333)). * Retry on 504 when calling the permission API ([#4355](#4355)).
renaudhartert-db
added a commit
that referenced
this pull request
Dec 30, 2024
### Bug Fixes * Reflect backend updates in state for databricks_app ([#4337](#4337)). ### Documentation * Update `databricks_workspace_conf` documentation ([#4334](#4334)). * apply `make fmt-docs` to all docs ([#4344](#4344)). ### Internal Changes * Generate both SdkV2-compatible and Plugin Framework-compatible structures ([#4332](#4332)). * Mark TestAccServicePrincipalResourceOnAzure test as flaky ([#4333](#4333)). * Retry on 504 when calling the permission API ([#4355](#4355)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 30, 2024
### Bug Fixes * Reflect backend updates in state for databricks_app ([#4337](#4337)). ### Documentation * Update `databricks_workspace_conf` documentation ([#4334](#4334)). * apply `make fmt-docs` to all docs ([#4344](#4344)). ### Internal Changes * Generate both SdkV2-compatible and Plugin Framework-compatible structures ([#4332](#4332)). * Mark TestAccServicePrincipalResourceOnAzure test as flaky ([#4333](#4333)). * Retry on 504 when calling the permission API ([#4355](#4355)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds logic to retry failed get calls to the permissions API when the error is a 504. This solution is meant to be temporary and will be removed as soon as such retries are handled natively in the Databricks Go SDK.
Tests
Complete coverage of the added retrier.