Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Reflect backend updates in state for databricks_app #4337

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

rauchy
Copy link
Contributor

@rauchy rauchy commented Dec 20, 2024

Changes

Following #4099, updates to Databricks Apps only reflected the ones in the plan, and not the ones coming back from the backend call to update the app. This PR includes those changes in.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@rauchy rauchy requested review from a team as code owners December 20, 2024 11:50
@rauchy rauchy requested review from parthban-db and removed request for a team December 20, 2024 11:50
@rauchy rauchy temporarily deployed to test-trigger-is December 20, 2024 11:51 — with GitHub Actions Inactive
@rauchy rauchy requested a review from mgyucht December 20, 2024 11:51
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4337
  • Commit SHA: 04702ec871d354f58407c6f78d610f2df8f82acb

Checks will be approved automatically on success.

@rauchy rauchy temporarily deployed to test-trigger-is December 20, 2024 11:51 — with GitHub Actions Inactive
@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/12430916907

@rauchy rauchy changed the title [FIX] Reflect backend updates in state for databricks_app [Fix] Reflect backend updates in state for databricks_app Dec 20, 2024
@mgyucht mgyucht added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 4c61683 Dec 20, 2024
13 of 14 checks passed
@mgyucht mgyucht deleted the omer-lachish_data/deco-24206-app-not-updated branch December 20, 2024 13:22
renaudhartert-db added a commit that referenced this pull request Dec 30, 2024
### Bug Fixes

 * Reflect backend updates in state for databricks_app ([#4337](#4337)).

### Documentation

 * Update `databricks_workspace_conf` documentation ([#4334](#4334)).
 * apply `make fmt-docs` to all docs ([#4344](#4344)).

### Internal Changes

 * Generate both SdkV2-compatible and Plugin Framework-compatible structures ([#4332](#4332)).
 * Mark TestAccServicePrincipalResourceOnAzure test as flaky ([#4333](#4333)).
 * Retry on 504 when calling the permission API ([#4355](#4355)).
renaudhartert-db added a commit that referenced this pull request Dec 30, 2024
### Bug Fixes

 * Reflect backend updates in state for databricks_app ([#4337](#4337)).

### Documentation

 * Update `databricks_workspace_conf` documentation ([#4334](#4334)).
 * apply `make fmt-docs` to all docs ([#4344](#4344)).

### Internal Changes

 * Generate both SdkV2-compatible and Plugin Framework-compatible structures ([#4332](#4332)).
 * Mark TestAccServicePrincipalResourceOnAzure test as flaky ([#4333](#4333)).
 * Retry on 504 when calling the permission API ([#4355](#4355)).
github-merge-queue bot pushed a commit that referenced this pull request Dec 30, 2024
### Bug Fixes

* Reflect backend updates in state for databricks_app
([#4337](#4337)).


### Documentation

* Update `databricks_workspace_conf` documentation
([#4334](#4334)).
* apply `make fmt-docs` to all docs
([#4344](#4344)).


### Internal Changes

* Generate both SdkV2-compatible and Plugin Framework-compatible
structures
([#4332](#4332)).
* Mark TestAccServicePrincipalResourceOnAzure test as flaky
([#4333](#4333)).
* Retry on 504 when calling the permission API
([#4355](#4355)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants