Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add support for setting table tags via terraform #4285

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

hshahconsulting
Copy link

Changes

Add support for setting table tags via terraform.

Fork of #3268

https://docs.databricks.com/en/data-governance/unity-catalog/tags.html

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@hshahconsulting hshahconsulting requested review from a team as code owners December 2, 2024 13:58
@hshahconsulting hshahconsulting requested review from tanmay-db and removed request for a team December 2, 2024 13:58
@tanmay-db
Copy link
Contributor

Thanks for the PR! @hshahconsulting , waiting for tests to finish

@alexott alexott temporarily deployed to test-trigger-is January 2, 2025 13:54 — with GitHub Actions Inactive
@alexott
Copy link
Contributor

alexott commented Jan 2, 2025

@hshahconsulting can you please make integration test compilable? There was a refactoring of the code in the integration tests package, and this broke the code for older PRs

@hshahconsulting
Copy link
Author

@hshahconsulting can you please make integration test compilable? There was a refactoring of the code in the integration tests package, and this broke the code for older PRs

Hello @alexott, I have made changes. Please check.

# Conflicts:
#	docs/resources/sql_table.md
Copy link

github-actions bot commented Jan 8, 2025

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4285
  • Commit SHA: 1136f5e5020bd661f9d9966c37fe980a61d389c4

Checks will be approved automatically on success.

@kthejoker
Copy link

Are there plans to extend this PR to allow tagging of other UC assets (catalog/schema)?

@hshahconsulting
Copy link
Author

Are there plans to extend this PR to allow tagging of other UC assets (catalog/schema)?

Not for this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants