Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Add tag for SQL warehouse used in Online Table tests #3905

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

mgyucht
Copy link
Contributor

@mgyucht mgyucht commented Aug 14, 2024

Changes

The TestUcAccOnlineTable test fails because it uses a SQL warehouse that does not have an owner tag, as required by policy for our internal accounts. This PR adds this tag.

Tests

Ran the test locally, and it passes.

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@mgyucht mgyucht marked this pull request as ready for review August 14, 2024 18:57
@mgyucht mgyucht requested review from a team as code owners August 14, 2024 18:57
@mgyucht mgyucht requested review from hectorcast-db and removed request for a team August 14, 2024 18:57
@alexott alexott added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit 785bcab Aug 14, 2024
7 checks passed
@alexott alexott deleted the fix-integration-tests-for-online-table branch August 14, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants