Skip to content

Commit

Permalink
more comment cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
shreyas-goenka committed Apr 10, 2024
1 parent 649f58c commit 51da5c6
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 17 deletions.
2 changes: 0 additions & 2 deletions .goreleaser.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ archives:
# file name then additional logic to clean up older builds would be needed.
name_template: 'databricks_cli_{{ if not .IsSnapshot }}{{ .Version }}_{{ end }}{{ .Os }}_{{ .Arch }}'

# TODO: Add some documentation / a readme to the docker directory on how to maintain this.

dockers:
- id: arm64
goarch: arm64
Expand Down
15 changes: 0 additions & 15 deletions docker/setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,3 @@ mv zip/terraform/terraform /app/bin/terraform
TF_PROVIDER_NAME=terraform-provider-databricks_${DATABRICKS_TF_PROVIDER_VERSION}_linux_${ARCH}.zip
mkdir -p /app/providers/registry.terraform.io/databricks/databricks
wget https://github.com/databricks/terraform-provider-databricks/releases/download/v${DATABRICKS_TF_PROVIDER_VERSION}/${TF_PROVIDER_NAME} -O /app/providers/registry.terraform.io/databricks/databricks/${TF_PROVIDER_NAME}


# TODO: document both the interactive and the non interactive workflows for
# working with DABs with the docker container. Execing into the container
# allows for a better iteration loop

# For the interactive devloop:
# docker run -it --entrypoint /bin/sh cli ...

# For the non-interactive devloop:
# docker run cli ...

# TODO: End to end test for this image?

# TODO: Final sanity check that the docker image is indeed airgapped.

0 comments on commit 51da5c6

Please sign in to comment.