feat(dashmate): check port reachability on setup #1283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshenmic
requested review from
shumkov,
antouhou and
QuantumExplorer
as code owners
pshenmic
force-pushed
the
feat/dashmate-reachability
branch
from
8798c21 to
420984b
Compare
shumkov
requested changes
Oct 23, 2023
| const publicIp = require('public-ip'); | ||
| const wait = require('./wait'); | ||
|
|
||
| async function resolvePublicIpV4() { |
There was a problem hiding this comment.
We should use it here as well
|
|
||
| async function resolvePublicIpV4() { | ||
| return Promise.race([ | ||
| publicIp.v4().catch(() => null), |
There was a problem hiding this comment.
We need to check both external IP + port
| @@ -141,6 +145,25 @@ function setupRegularPresetTaskFactory( | |||
| enabled: (ctx) => ctx.isMasternodeRegistered || ctx.nodeType === NODE_TYPE_FULLNODE, | |||
| task: () => configureNodeTask(), | |||
| }, | |||
| { | |||
| enabled: (ctx) => true, | |||
There was a problem hiding this comment.
You need to validate those in createIpAndPortsForm
|
@pshenmic please reopen PR if you are going to finish it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only