tests: enabled identity test suite tests

dashpay · Oct 30, 2023 · fc08fe1 · fc08fe1
1 parent 5c7ae92
commit fc08fe1
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 21 deletions.
diff --git a/packages/platform-test-suite/test/functional/platform/Identity.spec.js b/packages/platform-test-suite/test/functional/platform/Identity.spec.js
@@ -23,21 +23,23 @@ const {
     IdentityPublicKey,
     InvalidInstantAssetLockProofSignatureError,
     IdentityAssetLockTransactionOutPointAlreadyExistsError,
-    IdentityAssetLockTransactionNotFoundError,
     BalanceIsNotEnoughError,
     BasicECDSAError,
     IdentityPublicKeyWithWitness,
+    IdentityInsufficientBalanceError,
   },
 } = Dash;
 
-describe.only('Platform', () => {
-  describe('Identity', () => {
+describe('Platform',() => {
+  describe('Identity', function describeIdentity() {
+    this.bail(true); // bail on first failure
+
     let client;
     let identity;
     let walletAccount;
 
     before(async () => {
-      client = await createClientWithFundedWallet(1100000);
+      client = await createClientWithFundedWallet(20000000);
 
       walletAccount = await client.getWalletAccount();
     });
@@ -323,8 +325,9 @@ describe.only('Platform', () => {
         });
       });
 
-      it('should fail to create more documents if there are no more credits', async () => {
-        const lowBalanceIdentity = await client.platform.identities.register(50000);
+      // TODO: there is a bug in identity create balance validation
+      it.skip('should fail to create more documents if there are no more credits', async () => {
+        const lowBalanceIdentity = await client.platform.identities.register(80000);
 
         const document = await client.platform.documents.create(
           'customContracts.niceDocument',
@@ -356,21 +359,23 @@ describe.only('Platform', () => {
           transaction,
           privateKey,
           outputIndex,
-        } = await client.platform.identity.utils.createAssetLockTransaction(15);
+        } = await client.platform.identities.utils.createAssetLockTransaction(15);
 
         const instantLock = createFakeInstantLock(transaction.hash);
         const assetLockProof = await client.platform.dpp.identity
-          .createInstantAssetLockProof(instantLock);
+          .createInstantAssetLockProof(
+            instantLock.toBuffer(),
+            transaction.toBuffer(),
+            outputIndex,
+          );
 
         const identityTopUpTransition = client.platform.dpp.identity
           .createIdentityTopUpTransition(
             identity.getId(),
-            transaction,
-            outputIndex,
             assetLockProof,
           );
         await identityTopUpTransition.signByPrivateKey(
-          privateKey,
+          privateKey.toBuffer(),
           IdentityPublicKey.TYPES.ECDSA_SECP256K1,
         );
 
@@ -387,7 +392,7 @@ describe.only('Platform', () => {
         expect(broadcastError).to.exist();
         expect(broadcastError).to.be.an.instanceOf(StateTransitionBroadcastError);
         expect(broadcastError.getCause()).to.be.an.instanceOf(
-          IdentityAssetLockTransactionNotFoundError,
+          InvalidInstantAssetLockProofSignatureError,
         );
       });
 
@@ -396,7 +401,7 @@ describe.only('Platform', () => {
           identity.getId(),
         );
         const balanceBeforeTopUp = identityBeforeTopUp.getBalance();
-        const topUpAmount = 20000;
+        const topUpAmount = 1000000;
         const topUpCredits = topUpAmount * 1000;
 
         await client.platform.identities.topUp(identity.getId(), topUpAmount);
@@ -450,9 +455,13 @@ describe.only('Platform', () => {
 
         const identityTopUpTransitionOne = await client.platform.identities.utils
           .createIdentityTopUpTransition(assetLockProof, privateKey, identity.getId());
+
         // Creating ST that tries to spend the same output
+
+        const anotherIdentity = await client.platform.identities.register(100000);
+
         const conflictingTopUpStateTransition = await client.platform.identities.utils
-          .createIdentityTopUpTransition(assetLockProof, privateKey, identity.getId());
+          .createIdentityTopUpTransition(assetLockProof, privateKey, anotherIdentity.getId());
 
         await client.platform.broadcastStateTransition(
           identityTopUpTransitionOne,
@@ -528,19 +537,22 @@ describe.only('Platform', () => {
             identity.getId(),
           );
 
+          let transferError;
+
           try {
             await client.platform.identities.creditTransfer(
               identity,
               recipient.getId(),
               identity.getBalance() + 1,
             );
-
-            expect.fail('should throw an error');
           } catch (e) {
-            expect(e).to.be.an.instanceOf(StateTransitionBroadcastError);
-
-            expect(e.message.startsWith(`Insufficient identity $${identity.getId()} balance`)).to.be.true();
+            transferError = e;
           }
+
+          expect(transferError).to.exist();
+          expect(transferError).to.be.an.instanceOf(StateTransitionBroadcastError);
+          expect(transferError.getCause()).to.be.an.instanceOf(IdentityInsufficientBalanceError);
+          expect(transferError.getCause().getIdentityId()).to.deep.equal(identity.getId());
         });
       });
     });

diff --git a/packages/wasm-dpp/src/errors/consensus/basic/identity/identity_insufficient_balance_error.rs b/packages/wasm-dpp/src/errors/consensus/basic/identity/identity_insufficient_balance_error.rs
@@ -1,8 +1,10 @@
 use crate::buffer::Buffer;
+use crate::identifier::IdentifierWrapper;
 use dpp::consensus::codes::ErrorWithCode;
 use dpp::consensus::state::identity::IdentityInsufficientBalanceError;
 use dpp::consensus::ConsensusError;
 use dpp::serialization::PlatformSerializable;
+use std::ops::Deref;
 use wasm_bindgen::prelude::*;
 
 #[wasm_bindgen(js_name=IdentityInsufficientBalanceError)]
@@ -19,8 +21,8 @@ impl From<&IdentityInsufficientBalanceError> for IdentityInsufficientBalanceErro
 #[wasm_bindgen(js_class=IdentityInsufficientBalanceError)]
 impl IdentityInsufficientBalanceErrorWasm {
     #[wasm_bindgen(js_name=getIdentityId)]
-    pub fn identity_id(&self) -> Buffer {
-        Buffer::from_bytes(self.inner.identity_id.as_bytes())
+    pub fn identity_id(&self) -> IdentifierWrapper {
+        (*self.inner.identity_id()).into()
     }
 
     #[wasm_bindgen(js_name=getBalance)]