Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable coverage linter for functional tests #6479

Merged
merged 6 commits into from
Dec 15, 2024
Merged

feat: enable coverage linter for functional tests #6479

merged 6 commits into from
Dec 15, 2024

Conversation

knst
Copy link
Collaborator

@knst knst commented Dec 11, 2024 •
edited
Loading

Issue being fixed or feature implemented

https://github.com/dashpay/dash-issues/issues/63

What was done?

Add functional tests for getblockheaders
Hide RPC cleardiscouraged (as it is used only for functional tests) and RPC getpoolinfo (deprecated long time ago)
Add a workaround to ignore these RPCs getmerkleblocks, voteraw, debug, coinjoinsalt at the moment
Enables linter for coverage

How Has This Been Tested?

Run locally with test/functional/test_runner.py -j20 --previous-releases --coverage --extended
Enabled in CI

Breaking Changes

N/A if hidding cleardiscouraged is not a breaking change.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

@knst knst added this to the 22.1 milestone Dec 11, 2024
@knst knst added the RPC Some notable changes to RPC params/behaviour/descriptions label Dec 11, 2024
@UdjinM6
Copy link

UdjinM6 commented Dec 11, 2024 

Uncovered RPC commands:
  - cleardiscouraged
  - coinjoinsalt
  - debug
  - getmerkleblocks
  - voteraw

https://gitlab.com/dashpay/dash/-/jobs/8612503149

@knst knst marked this pull request as draft December 11, 2024 15:33
@knst knst force-pushed the feat-enable-coverage branch 2 times, most recently from f56e7cb to e0c580e Compare December 13, 2024 14:13
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please rebase.

@knst knst force-pushed the feat-enable-coverage branch from e0c580e to 2e509b9 Compare December 13, 2024 14:19
@knst knst marked this pull request as ready for review December 13, 2024 23:57
UdjinM6
UdjinM6 approved these changes Dec 14, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, utACK 2e509b9

@knst knst mentioned this pull request Dec 15, 2024
Merged
5 tasks
PastaPastaPasta
PastaPastaPasta approved these changes Dec 15, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 2e509b9

@PastaPastaPasta
Copy link
Member

nit, please be more careful with commit naming in future. Commits should probably be

* 2e509b96c4870d2c5717d15d7d3c9614c31ae41e fix: add a workaround for RPC getmerkleblocks, debug, coinjoinsalt, voteraw (Konstantin Akimov) (pull/6479/head)
* f0decc879085e9689c780112322167dea63409e7 test: add unit test for ClearDiscouraged (Konstantin Akimov)
* 865b24ea00a17cc61cf8bb55499cb384761cb94c feat: hide cleardiscouraged RPC so far as it no intent to use by regular users (Konstantin Akimov)
* 1f5fa7e7cfb1142cfda5f27a9a02552a5ee57f16 ci: enable linter coverage for functional tests (Konstantin Akimov)
* 59ddac5656a44b1a5c4c317ac9317b0d47a01951 feat: hide deprecated RPC from help and add TODOes to remove them (Konstantin Akimov)
* 05732aceafa831cca485911b63fb63bcedc8ca82 test: implement functional tests for RPC getblockheaders (Konstantin Akimov)

@PastaPastaPasta PastaPastaPasta merged commit 032fc21 into dashpay:develop Dec 15, 2024
21 checks passed
@knst knst deleted the feat-enable-coverage branch December 17, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@UdjinM6 UdjinM6 Awaiting requested review from UdjinM6

Assignees
No one assigned
Labels
RPC Some notable changes to RPC params/behaviour/descriptions
Projects
None yet
Milestone
22.1
Development

Successfully merging this pull request may close these issues.
3 participants
@knst @UdjinM6 @PastaPastaPasta