fix: unlock proregtx collateral on error #5838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| SignSpecialTxPayloadByString(tx, ptx, key); | ||
| SetTxPayload(tx, ptx); | ||
| return SignAndSendSpecialTx(request, chainman, tx, fSubmit); | ||
| throw; |
There was a problem hiding this comment.
why is there a naked throw?
There was a problem hiding this comment.
bcs need to re-throw the exception which has been caught by except without changing logic of code. If throw is naked - it throws the last exception again.
But I'd suggest to write here a wrapper around Lock/Unlock same as 'lock_guard + mutex works'.
When creating a proregtx unlock the external collateral if creation fails
panleone
force-pushed
the
unlock_on_fail
branch
from
4faaf09 to
8f09b4e
Compare
PastaPastaPasta
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed
Unlock the (external) collateral of a proregtx if creation fails for any reason.
What was done?
See commit description
Checklist: