fix: make llmq_test_instantsend great again

[knst]

Issue being fixed or feature implemented

Running 3 nodes on RegTest as platform does uses do not let to create llmq_test_instantsend quorum:

1. switch to `llmq_test_instantsend`:
+        self.extra_args = [["-llmqtestinstantsenddip0024=llmq_test_instantsend"]] * 5

2. removed cycle-quorum related code:

-        self.move_to_next_cycle()
-        self.log.info("Cycle H height:" + str(self.nodes[0].getblockcount()))
-        self.move_to_next_cycle()
-        self.log.info("Cycle H+C height:" + str(self.nodes[0].getblockcount()))
-        self.move_to_next_cycle()
-        self.log.info("Cycle H+2C height:" + str(self.nodes[0].getblockcount()))
-
-        self.mine_cycle_quorum(llmq_type_name='llmq_test_dip0024', llmq_type=103)

3. added new quorum:

+        self.mine_quorum(llmq_type_name='llmq_test_instantsend', llmq_type=104)

and eventually it stucked, no quorum happens

2024-01-13T19:18:49.317000Z TestFramework (INFO): Expected quorum_0 at:984
2024-01-13T19:18:49.317000Z TestFramework (INFO): Expected quorum_0 hash:6788e18f0235a5c85f3d3c6233fe132a80e74a2912256db3ad876a8ebf026048
2024-01-13T19:18:49.317000Z TestFramework (INFO): quorumIndex 0: Waiting for phase 1 (init)
<frozen>

What was done?

Updated condition to enable "llmq_test_instantsend":

• it is RegTest and DIP0024 is not active
• it is RegTest, DIP0024 is active, and specified as llmqTypeDIP0024InstantSend

How Has This Been Tested?

Run unit and functional tests.
Beside that functional test feature_asset_locks.py now uses this quorum for instant send and that's an arrow that hit 2 birds: we have test for command line option -llmqtestinstantsenddip0024 and code of feature_asset_locks.py is simplified.

Breaking Changes

yes, that's a bugfix that fix quorum llmq_test_instantsend absentance on regtest after dip-0024 activation.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[knst]

Label guix-build is set to get a docker image for platform

[DashCoreAutoGuix]

test message

[DashCoreAutoGuix]

Guix Automation has began to build this PR tagged as v20.1.0-devpr5832.8512c1cb. A new comment will be made when the image is pushed.

[DashCoreAutoGuix]

Guix Automation has began to build this PR tagged as v20.1.0-devpr5832.2c60a16d. A new comment will be made when the image is pushed.

[DashCoreAutoGuix]

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v20.1.0-devpr5832.2c60a16d. The image should be on dockerhub soon.

[knst]

@markin-io confirmed it works

@UdjinM6 @PastaPastaPasta please review to get it to nightly builds

[UdjinM6]

utACK

[PastaPastaPasta]

utACK for squash merge