Skip to content

Commit

Permalink
Merge #6506: test: increase timeout in p2p_invalid_messages.py to r…
Browse files Browse the repository at this point in the history
…educe flakiness

c67d5ee test: increase timeout in `p2p_invalid_messages.py` to reduce flakiness (Kittywhiskers Van Gogh)

Pull request description:

  ## Additional Information

  * Dependency for #6504
  *  `p2p_invalid_messages.py` has a tendency to occasionally fail and when working on [dash#6504](#6504), the test had a higher failure rate than usual (despite the rest of the test suite passing and with exception to the `test_buffer` subtest, the rest of `p2p_invalid_messages.py` passing)

     This pull request bumps the timeout from 1s to 2s only in the `test_buffer` subtest.

  ## Breaking Changes

  None expected.

  ## Checklist:

  - [x] I have performed a self-review of my own code
  - [x] I have commented my code, particularly in hard-to-understand areas (note: N/A)
  - [x] I have added or updated relevant unit/integration/functional/e2e tests
  - [x] I have made corresponding changes to the documentation (note: N/A)
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  PastaPastaPasta:
    utACK c67d5ee
  knst:
    utACK c67d5ee
  UdjinM6:
    utACK c67d5ee

Tree-SHA512: 88c13efad733d4685c65343fd40e1b80603c24955dd3f0f97aceedef8dd4e060d6e2bb3c3a1a2f18f288dc2ef55ec3f4df6a18b524674c2964ecc1724b6adf00
  • Loading branch information
PastaPastaPasta committed Dec 26, 2024
2 parents 2bd4703 + c67d5ee commit b2f8e07
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/functional/p2p_invalid_messages.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def test_buffer(self):
# However the pong from conn in reply to the ping from the node has not
# been processed and recorded in totalbytesrecv.
# Flush the pong from conn by sending a ping from conn.
conn.sync_with_ping(timeout=1)
conn.sync_with_ping(timeout=2)
# Create valid message
msg = conn.build_message(msg_ping(nonce=12345))
cut_pos = 12 # Chosen at an arbitrary position within the header
Expand All @@ -82,7 +82,7 @@ def test_buffer(self):
middle = self.nodes[0].getnettotals()['totalbytesrecv']
assert_equal(middle, before + cut_pos)
conn.send_raw_message(msg[cut_pos:])
conn.sync_with_ping(timeout=1)
conn.sync_with_ping(timeout=2)
self.nodes[0].disconnect_p2ps()

def test_duplicate_version_msg(self):
Expand Down

0 comments on commit b2f8e07

Please sign in to comment.