Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: start dashmate services depending on status #503
refactor: start dashmate services depending on status #503
Changes from 23 commits
3c6c3a3
ba6a4cf
d08a3b7
42227a9
1eb6539
12a8d98
51c5968
788e861
1adec64
b656904
7fff8ce
e9cb556
414a3e9
a4bbad3
02b08e5
0c92a06
1b8484c
b5dbe2a
7848224
0ce0f7d
4a06b95
f02b30d
cec1346
b51fb42
1bd0879
371c2ba
21c6582
bbd8e38
5ad5dfd
cdd4049
fa503a0
ec8f134
883475f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if tenderdash is stopped it Drive or DAPI is started?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean? Should I rather check by drive container?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if one of them started?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm worried that it will add more fragility to the code. We actually don't have them stopped separately from each other. Tenderdash container will be either in
not_started
state orrunning
. If there are any issues happening, it will remain inrestarting
,exited
, or any other states, and tasks will be skippedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What will happen if tenderdash is stopped but any of platform services is running? DAPI for example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you we want to configure this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because when we install from branch, we don't have dashmate_version available and it will back off to
999.0.0
which will break template idempotency. On the first dashmate run, config version will be overwritten with the package default version.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Yes you right. Would it be better to get dashmate version form dashmate itself (
dashmate --version
orpackage.json
) so you won't need to configure it manually.999.0.0
workaround won't be necessary as well.