Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Environment Variable Editor #159

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ThomasJRyan
Copy link

@ThomasJRyan ThomasJRyan commented Dec 14, 2024

This PR adds an environment variable editor to the command palette.

A large change has been made to the SharedVariables class to allow differentiation of multiple environment files instead of having them all merging into a single group of variables.

Most of the functionality was a merge of the Help Screen and Headers widget.

Environment file watching has been commented out due to it being annoying when modifying variables in-app. I think I'd rather find a way to keep it and just not have it fire off when changed from Posting

TODO:

  • Focus should be given to the EnvironmentTable after an env file is selected in the Select
  • A setting should be provided to disable writing to env files
  • It'd be nice to be able to edit variables in-place instead of having to remove and add them
  • Hotkey bindings
  • Ability to create env files for collections (though admittedly I might leave that for a later PR)
  • Test that PATH variables work and cannot be written to

Bugs:

  • Focus isn't given back to the app when the screen closes (the reset_focus callback isn't being called for some reason). The causes a crash when F1 is pressed immediately after closing the screen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant