First bunch of opencl 46 suggestions #598
Conversation
|
BTW - have just seen that you included lens vignetting and the backthumbs crawler stuff already. Do you have any questions about that or other things i left undocumented? |
|
If you could look over the stuff I've done and let me know if it needs anything more that'd be great. If there's anything more that's undocumented it's because I haven't started looking at it yet, so I don't yet know if I have questions. |
|
No, I checked my to-do list for updated dtdocs and there is only opencl stuff left out. |
|
Are you expecting to push some changes to the performance tuning section as well, to cover these alterations and those in darktable-org/darktable#15166? |
Absolutely! |
|
The second commit is about the device tuning ... checked for correctness, added some hints / suggestions.
|
|
Nice, thanks. I'll take a look at it this weekend |
- preferences - setting up Fix OpenCL tuning parameters docs - removed unvalid stuff residuals from 4.2/4.4 - updatad docs for shared mem fraction - some usage / setting hints sfdvdaf
jenshannoschwalm
force-pushed
the
opencl_46_1
branch
from
c9b28db to
b9c023d
Compare
|
More fixes, squashed and force-push a single commit for easier reviewing. I think the only opencl topic missing in this pr would be sheduling profiles ... That is certainly just partly wrong since some dt versions and needs some caretaking. As i don't use multiple devices myself it will need some testing and code reading, will likely be able to do that on the weekend but in another pr. |
|
LGTM thanks! |
@elstoc had messed up my authentication stuff ...