add IMAGE.ID.NEXT for the next image id to be assigned on import #17679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfbrown
added
feature: enhancement
TurboGit
added
priority: low
|
@ralfbrown : Can you draft a release note entry please? TIA. |
|
Already in the release notes. Documentation PR darktable-org/dtdocs#683 is pending. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$(ID)/$(IMAGE.ID)are not available for renaming in a copy&import session, but we can easily get the maximum image id currently in the database and add one to get the next image id to be assigned[*]. This PR adds a new variable$(IMAGE.ID.NEXT)which substitutes in exactly that value. It takes an optional parameter specifying how many zero-padded digits to use, e.g.$(IMAGE.ID.NEXT[5])would return 00001 for an empty library. Also added the same optional parameter to$(ID)and$(IMAGE.ID)to permit a fixed field size when substituting.[*] There is one corner case which is not handled - if one imports some images, removes the one(s) with highest id(s) and then imports again, the first image in the new session gets a value other than its ultimate image id substituted in.
Resolves #17676.