Add newline char at end of dapr version output (#1014)

* add newline character at end of output of dapr version cmd Signed-off-by: Mukundan Sundararajan <[email protected]> * add newline char to dapr --version flag Signed-off-by: Mukundan Sundararajan <[email protected]> * refactor version template string Signed-off-by: Mukundan Sundararajan <[email protected]>
dapr · Jun 28, 2022 · f58c920 · f58c920
1 parent 23e8b8b
commit f58c920
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/cmd/dapr.go b/cmd/dapr.go
@@ -72,7 +72,7 @@ func Execute(version, apiVersion string) {
 }
 
 func setVersion() {
-	template := fmt.Sprintf("CLI version: %s \nRuntime version: %s", daprVer.CliVersion, daprVer.RuntimeVersion)
+	template := fmt.Sprintf(cliVersionTemplateString, daprVer.CliVersion, daprVer.RuntimeVersion)
 	RootCmd.SetVersionTemplate(template)
 }
 

diff --git a/cmd/version.go b/cmd/version.go
@@ -23,6 +23,8 @@ import (
 	"github.com/dapr/cli/pkg/print"
 )
 
+const cliVersionTemplateString = "CLI version: %s \nRuntime version: %s\n"
+
 var output string
 
 var VersionCmd = &cobra.Command{
@@ -40,15 +42,15 @@ dapr version --output json
 		switch output {
 		case "":
 			// normal output.
-			fmt.Printf("CLI version: %s \nRuntime version: %s", daprVer.CliVersion, daprVer.RuntimeVersion)
+			fmt.Printf(cliVersionTemplateString, daprVer.CliVersion, daprVer.RuntimeVersion)
 		case "json":
 			// json output.
 			b, err := json.Marshal(daprVer)
 			if err != nil {
 				print.FailureStatusEvent(os.Stderr, err.Error())
 				os.Exit(1)
 			}
-			fmt.Printf("%s", string(b))
+			fmt.Printf("%s\n", string(b))
 		default:
 			// fail and exit.
 			os.Exit(1)