Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: raise msrv (1.83.0) rust toolchain (1.84.0) #5374

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

tessus
Copy link
Contributor

@tessus tessus commented Jan 9, 2025

allows to merge #5260

see also: #5260 (comment)

@BlackDex
Copy link
Collaborator

BlackDex commented Jan 9, 2025

Missing the docker changes here.
Also, the rust docker images are not yet published.

dani-garcia
dani-garcia previously approved these changes Jan 9, 2025
Copy link
Owner

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the reminder about the other PR

@tessus
Copy link
Contributor Author

tessus commented Jan 9, 2025

@BlackDex Ah, I see. in this case I'll wait and update the PR then.

P.S.: Although this might take a while. slim-bookworm 1.83 was only pushed 2 weeks ago. If we use this as an indicator, we might have to wait for about a month.

@dani-garcia
Copy link
Owner

dani-garcia commented Jan 9, 2025

Yeah the docker image build seems to be a manual process, usually only takes a couple of hours/days though:

https://github.com/docker-library/official-images/commits/master/library/rust

The PR for 1.84 is here: docker-library/official-images#18214

@dfunkt
Copy link
Contributor

dfunkt commented Jan 9, 2025

Let's not forget about the scheduled builds for the alpine builder images (https://github.com/BlackDex/rust-musl/actions). This PR should be merged after the 1.84.0 versions are available here -> https://github.com/BlackDex/rust-musl/pkgs/container/rust-musl

@tessus
Copy link
Contributor Author

tessus commented Jan 9, 2025

@dfunkt I have already made the changes locally. I'll commit and push the docker changes when the official and blackdex's musl images are available.

edit:

  • rust:1.84.0-slim-bookworm
  • blackdex/rust-musl:*-musl-stable-1.84.0

@BlackDex
Copy link
Collaborator

@tessus the images are built btw. They are also now signed via attestation

Copy link
Collaborator

@BlackDex BlackDex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@dani-garcia dani-garcia merged commit 16b6d2a into dani-garcia:main Jan 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants