-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: raise msrv (1.83.0) rust toolchain (1.84.0) #5374
Conversation
Missing the docker changes here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the reminder about the other PR
@BlackDex Ah, I see. in this case I'll wait and update the PR then. P.S.: Although this might take a while. slim-bookworm 1.83 was only pushed 2 weeks ago. If we use this as an indicator, we might have to wait for about a month. |
Yeah the docker image build seems to be a manual process, usually only takes a couple of hours/days though: https://github.com/docker-library/official-images/commits/master/library/rust The PR for 1.84 is here: docker-library/official-images#18214 |
Let's not forget about the scheduled builds for the alpine builder images (https://github.com/BlackDex/rust-musl/actions). This PR should be merged after the 1.84.0 versions are available here -> https://github.com/BlackDex/rust-musl/pkgs/container/rust-musl |
@dfunkt I have already made the changes locally. I'll commit and push the docker changes when the official and blackdex's musl images are available. edit:
|
@tessus the images are built btw. They are also now signed via attestation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
allows to merge #5260
see also: #5260 (comment)