Run rustfmt on the srcs. #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned in #11 ... |
| @@ -487,8 +512,10 @@ mod test { | |||
| #[test] | |||
| fn test_drop_db() { | |||
| let dir = TempDir::new("test").unwrap(); | |||
| let env = Environment::new().set_max_dbs(2) | |||
| .open(dir.path()).unwrap(); | |||
| let env = Environment::new() | |||
There was a problem hiding this comment.
The formatting here before was clearly bad, but I think I'd prefer a 'chop-down' style if rustfmt can support it, e.g.
let env = Environment::new().set_max_dbs(2)
.open(dir.path())
.unwrap();
|
@waywardmonkeys thanks for the PR. I'm going to be unresponsive for the next week, but I'll check back in then. Pretty much looks good except for the one nit. |
| @@ -61,7 +64,9 @@ pub trait Cursor<'txn> { | |||
| /// For databases with duplicate data items (`DatabaseFlags::DUP_SORT`), the | |||
| /// duplicate data items of each key will be returned before moving on to | |||
| /// the next key. | |||
| fn iter_from<K>(&mut self, key: K) -> Iter<'txn> where K: AsRef<[u8]> { | |||
| fn iter_from<K>(&mut self, key: K) -> Iter<'txn> | |||
There was a problem hiding this comment.
This wrapping is a little too aggressive. I think
where_density = "Compressed"
would make it better
|
I spent some time fiddling with |
|
Going to close this as I don't plan to update it and it doesn't apply. Someone can create a new one by just running |
ncloudioj
pushed a commit
to ncloudioj/lmdb-rs
that referenced
this pull request
Mar 13, 2019
update minor version for breaking change to Cursor::iter_dup_of
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.