Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustfmt #11

Open
waywardmonkeys opened this issue Jul 20, 2016 · 1 comment
Open

rustfmt #11

waywardmonkeys opened this issue Jul 20, 2016 · 1 comment

Comments

@waywardmonkeys
Copy link
Contributor

I'd like to make some other changes and submit them, but I have my editor set to run rustfmt by default when saving a file. I can obviously disable this, but would a pull request that only runs rustfmt be welcome?
@danburkert
Copy link
Owner

I'm open to this, but only if rustfmt can be configured to be fairly close to the existing style. Last time I checked out rustfmt it had a bunch of idiosyncrasies and rough edges, and I wasn't able to get it to do what I wanted (admittedly this was almost a year ago). If you want to throw up a PR we can take it from there. Thanks!

@waywardmonkeys waywardmonkeys mentioned this issue Jul 21, 2016
Closed
@cmbrandenburg cmbrandenburg mentioned this issue Jun 18, 2017
Merged
danburkert pushed a commit that referenced this issue Jun 25, 2017
@cmbrandenburg @danburkert
Disable rustfmt by default (#14)
14a5332 
This effects issue #11.
ncloudioj pushed a commit to ncloudioj/lmdb-rs that referenced this issue Mar 13, 2019
@mykmelez
Merge pull request danburkert#11 from mykmelez/correct-default-map-size
7e4914e 
correct size of default memory map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danburkert @waywardmonkeys