Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Articlegrid #4

Merged
merged 8 commits into from
Oct 30, 2024
Merged

Articlegrid #4

merged 8 commits into from
Oct 30, 2024

Conversation

maxfukuh4ra
Copy link
Contributor

Description

  • Implemented ArticleGrid component. Currently no ArticleCard component is published so it will not render properly.
  • CSS styling using % instead of hard coding pixels
  • App.js implementation of 3 separate grids using .national, .state, and .local data.

@tsakshi011
Copy link
Contributor

Hi, the article card branch is now created you can pull from the branch .

@maxfukuh4ra
Copy link
Contributor Author

It works but I am unsure as to why the CSS styling for the grid is not setting to a certain percentage.

@donnyr5
Copy link

donnyr5 commented Oct 30, 2024

see comment on #5

tsakshi011
tsakshi011 reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@tsakshi011 tsakshi011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the article grid mobile friendly as well

@tsakshi011 tsakshi011 merged commit d77582b into main Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsakshi011 tsakshi011 tsakshi011 left review comments

@donnyr5 donnyr5 Awaiting requested review from donnyr5 donnyr5 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxfukuh4ra @tsakshi011 @donnyr5 @emilyzhang625