Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update header color #2

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Update header color #2

merged 3 commits into from
Oct 30, 2024

Conversation

jenniferylee
Copy link
Contributor

@jenniferylee jenniferylee commented Oct 20, 2024

Description

Please provide a summary of the changes made in this pull request:

  • Updated header color to blue from black

Checklist

  • I have performed a self-review of my own code
  • I have tested changes for mobile, if applicable

Screenshots

Please Include screenshots or links to visual changes for any new component (if applicable).
Screenshot 2024-10-20 at 11 54 11 AM

Copy link

@donnyr5 donnyr5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally you wouldn't commit the lock files since they should be the same for every person. This ensures everyone uses the same versions for dependencies. Make sure with Sakshi that you only did yarn install or npm install and nothing else to change the lock files. Maybe they were never committed properly in the first place which is why yours is very different.

Copy link
Contributor

@tsakshi011 tsakshi011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, would you mind removing the yarn.lock file as we are using npm. Ty!

@tsakshi011 tsakshi011 merged commit 4ebaa95 into main Oct 30, 2024
1 check passed
@jenniferylee jenniferylee deleted the Jennfer/Header branch October 30, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants