already fixed #420

dadhi · Oct 13, 2024 · 1d97907 · 1d97907
1 parent 7272c31
commit 1d97907
Show file tree

Hide file tree

Showing 3 changed files with 67 additions and 0 deletions.
diff --git a/...piler.IssueTests/Issue420_Nullable_DateTime_comparison_differs_from_Expression_Compile.cs b/...piler.IssueTests/Issue420_Nullable_DateTime_comparison_differs_from_Expression_Compile.cs
@@ -0,0 +1,60 @@
+using System;
+using System.Linq;
+using System.Linq.Expressions;
+using NUnit.Framework;
+
+#if LIGHT_EXPRESSION
+using FastExpressionCompiler.LightExpression;
+using static FastExpressionCompiler.LightExpression.Expression;
+namespace FastExpressionCompiler.LightExpression.IssueTests;
+#else
+using static System.Linq.Expressions.Expression;
+namespace FastExpressionCompiler.IssueTests;
+#endif
+
+[TestFixture]
+public class Issue420_Nullable_DateTime_comparison_differs_from_Expression_Compile : ITest
+{
+    public int Run()
+    {
+        Original_case();
+        return 1;
+    }
+
+    public class HasDateTime
+    {
+        public DateTime? T { get; }
+        public HasDateTime(DateTime? t) => T = t;
+    }
+
+    [Test]
+    public void Original_case()
+    {
+        var time = DateTime.UtcNow;
+
+        var p = new ParameterExpression[1]; // the parameter expressions
+        var e = new Expression[3]; // the unique expressions
+        var expr = Lambda<Func<HasDateTime, bool>>(
+            e[0] = MakeBinary(ExpressionType.Equal,
+                e[1] = Property(
+                    p[0] = Parameter(typeof(HasDateTime), nameof(HasDateTime)),
+                    typeof(HasDateTime).GetProperty(nameof(HasDateTime.T))),
+                e[2] = Constant(time, typeof(DateTime?)),
+                liftToNull: false,
+                typeof(DateTime).GetMethods().Single(x => !x.IsGenericMethod && x.Name == "op_Equality" && x.GetParameters().Select(y => y.ParameterType).SequenceEqual(new[] { typeof(System.DateTime), typeof(System.DateTime) }))),
+            p[0 // (HasDateTime)
+            ]);
+
+        expr.PrintCSharp();
+
+        var fs = expr.CompileSys();
+        fs.PrintIL();
+
+        var ff = expr.CompileFast(true, CompilerFlags.ThrowOnNotSupportedExpression);
+        ff.PrintIL();
+
+        var hasDT = new HasDateTime(time);
+        Assert.IsTrue(fs(hasDT));
+        Assert.IsTrue(ff(hasDT));
+    }
+}
diff --git a/test/FastExpressionCompiler.TestsRunner.Net472/Program.cs b/test/FastExpressionCompiler.TestsRunner.Net472/Program.cs
@@ -284,6 +284,9 @@ void Run(Func<int> run, string name = null)
                 Run(new Issue419_The_JIT_compiler_encountered_invalid_IL_code_or_an_internal_limitation().Run);
                 Run(new LightExpression.IssueTests.Issue419_The_JIT_compiler_encountered_invalid_IL_code_or_an_internal_limitation().Run);
 
+                Run(new Issue420_Nullable_DateTime_comparison_differs_from_Expression_Compile().Run);
+                Run(new LightExpression.IssueTests.Issue420_Nullable_DateTime_comparison_differs_from_Expression_Compile().Run);
+
                 Run(new Issue421_Date_difference_is_giving_wrong_negative_value().Run);
 
                 Run(new Issue422_InvalidProgramException_when_having_TryCatch_Default_in_Catch().Run);

diff --git a/test/FastExpressionCompiler.TestsRunner/Program.cs b/test/FastExpressionCompiler.TestsRunner/Program.cs
@@ -9,6 +9,7 @@ public class Program
     {
         public static void Main()
         {
+            // new LightExpression.IssueTests.Issue420_Nullable_DateTime_comparison_differs_from_Expression_Compile().Run();
             // new LightExpression.IssueTests.Issue419_The_JIT_compiler_encountered_invalid_IL_code_or_an_internal_limitation().Run();
             // new Issue421_Date_difference_is_giving_wrong_negative_value().Run();
             // new ArithmeticOperationsTests().Run();
@@ -318,6 +319,9 @@ void Run(Func<int> run, string name = null)
                 Run(new Issue419_The_JIT_compiler_encountered_invalid_IL_code_or_an_internal_limitation().Run);
                 Run(new LightExpression.IssueTests.Issue419_The_JIT_compiler_encountered_invalid_IL_code_or_an_internal_limitation().Run);
 
+                Run(new Issue420_Nullable_DateTime_comparison_differs_from_Expression_Compile().Run);
+                Run(new LightExpression.IssueTests.Issue420_Nullable_DateTime_comparison_differs_from_Expression_Compile().Run);
+
                 Run(new Issue421_Date_difference_is_giving_wrong_negative_value().Run);
 
                 Run(new Issue422_InvalidProgramException_when_having_TryCatch_Default_in_Catch().Run);