-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added show and hide password #63
Conversation
👷 Deploy request for daccotta pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey the changes seems good , just a small thing can you use lucide / tabler icons in instead of images from web in show / hide ?
@AshuKr22 ya sure doing it |
@sid0000007 kindly verify |
hey @Sourabh782 , can you make a new commit without the package-lock.json as it is creating conflicts with our current file. |
sure |
@AshuKr22 check now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
hey @Sourabh782 , the problem as of now is you deleted the package-lock.json file . it is not a viable solution as if we merge that , our package-lock.json file would also deleted. i suggest a workaround. go to daccotta's dev branch copy the package-lock.json file contents and add them to your lock file. it would eliminate all conflicts. |
Sure @AshuKr22 |
@AshuKr22 is it now ok? or i'll start from a fresh pull |
@AshuKr22 any update |
hey @Sourabh782 sorry for the late reply . the main package.json looks fine but the client package-json is still missing : |
Oh really sorry @AshuKr22 doing it now |
@AshuKr22 check now i have copied current package-lock.json from client folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Closes : #59
Added show hide password functionality