Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added show and hide password #63

Merged
merged 8 commits into from
Oct 10, 2024
Merged

Conversation

Sourabh782
Copy link
Contributor

Closes : #59

Added show hide password functionality

Screenshot 2024-10-05 201118
Screenshot 2024-10-05 201053
Screenshot 2024-10-05 200907

Copy link

netlify bot commented Oct 5, 2024

👷 Deploy request for daccotta pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c376df2

Copy link
Contributor

@AshuKr22 AshuKr22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey the changes seems good , just a small thing can you use lucide / tabler icons in instead of images from web in show / hide ?

@Sourabh782
Copy link
Contributor Author

@AshuKr22 ya sure doing it

@sid0000007 sid0000007 added bug Something isn't working gssoc-ext level 1 labels Oct 6, 2024
@daccotta-org daccotta-org deleted a comment from Sourabh782 Oct 6, 2024
@Sourabh782
Copy link
Contributor Author

@sid0000007 kindly verify

@Sourabh782 Sourabh782 requested a review from AshuKr22 October 6, 2024 15:58
@AshuKr22
Copy link
Contributor

AshuKr22 commented Oct 6, 2024

hey @Sourabh782 , can you make a new commit without the package-lock.json as it is creating conflicts with our current file.

@Sourabh782
Copy link
Contributor Author

sure

@Sourabh782
Copy link
Contributor Author

@AshuKr22 check now?

sid0000007
sid0000007 previously approved these changes Oct 8, 2024
Copy link
Contributor

@sid0000007 sid0000007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@AshuKr22
Copy link
Contributor

AshuKr22 commented Oct 8, 2024

hey @Sourabh782 , the problem as of now is you deleted the package-lock.json file . it is not a viable solution as if we merge that , our package-lock.json file would also deleted. i suggest a workaround. go to daccotta's dev branch copy the package-lock.json file contents and add them to your lock file. it would eliminate all conflicts.

@Sourabh782
Copy link
Contributor Author

Sure @AshuKr22

@Sourabh782
Copy link
Contributor Author

@AshuKr22 is it now ok? or i'll start from a fresh pull

@Sourabh782
Copy link
Contributor Author

@AshuKr22 any update

@AshuKr22
Copy link
Contributor

hey @Sourabh782 sorry for the late reply . the main package.json looks fine but the client package-json is still missing :
image

@Sourabh782
Copy link
Contributor Author

Oh really sorry @AshuKr22 doing it now

@Sourabh782
Copy link
Contributor Author

@AshuKr22 check now i have copied current package-lock.json from client folder

@sid0000007 sid0000007 dismissed their stale review October 10, 2024 10:45

new changes

Copy link
Contributor

@AshuKr22 AshuKr22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@AshuKr22 AshuKr22 merged commit 8489bd9 into daccotta-org:dev Oct 10, 2024
1 check passed
@AshuKr22 AshuKr22 mentioned this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc-ext level 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding password show/hide option
3 participants