Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Sign Up with Email Providers Other Than Gmail #245

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

amitb0ra
Copy link
Contributor

Fixed: #221

Users are currently unable to sign up using email providers other than Gmail. Attempting to register with providers such as Yahoo, Outlook, or custom domain emails results in an error or failed sign-up process. This issue is limiting the user base to only Gmail users, which may hinder the growth of the platform.

Copy link

netlify bot commented Oct 22, 2024

👷 Deploy request for daccotta pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 8e124db

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @amitb0ra for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

@AshuKr22
Copy link
Contributor

@amitb0ra how are you confirming that the input given by user is actually an email?. you should have implemented either some kind of regex or added checks for other input providers now anyone can input anything in email.

Copy link
Contributor

@AshuKr22 AshuKr22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add either regex or checks for if the value inputted by the user is actually an email or not.

@amitb0ra
Copy link
Contributor Author

amitb0ra commented Oct 22, 2024

is it okay? https://regexr.com/2rhq7

also, do you want specific route to check email? /check-email?

@amitb0ra
Copy link
Contributor Author

@AshuKr22 is it okay?

@AshuKr22
Copy link
Contributor

@amitb0ra yeah its good

Copy link
Contributor

@AshuKr22 AshuKr22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@AshuKr22 AshuKr22 merged commit 273c15b into daccotta-org:dev Oct 24, 2024
1 check passed
Copy link

🎉🎉 Thank you for your contribution! Your PR #245 has been merged! 🎉🎉

@amitb0ra
Copy link
Contributor Author

@AshuKr22 You forgot to add GSSoC'24 ext and hacktoberfest labels. Can you add them please

@amitb0ra amitb0ra deleted the issue/221-sign-up branch October 24, 2024 14:40
@amitb0ra
Copy link
Contributor Author

amitb0ra commented Nov 10, 2024

@sanjay-kv @AshuKr22 please provide labels in it. ITS IMPORTANT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Sign Up with Email Providers Other Than Gmail
2 participants