-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to Sign Up with Email Providers Other Than Gmail #245
Conversation
👷 Deploy request for daccotta pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you @amitb0ra for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better
@amitb0ra how are you confirming that the input given by user is actually an email?. you should have implemented either some kind of regex or added checks for other input providers now anyone can input anything in email. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add either regex or checks for if the value inputted by the user is actually an email or not.
is it okay? https://regexr.com/2rhq7 also, do you want specific route to check email? /check-email? |
@AshuKr22 is it okay? |
@amitb0ra yeah its good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
🎉🎉 Thank you for your contribution! Your PR #245 has been merged! 🎉🎉 |
@AshuKr22 You forgot to add GSSoC'24 ext and hacktoberfest labels. Can you add them please |
@sanjay-kv @AshuKr22 please provide labels in it. ITS IMPORTANT |
Fixed: #221
Users are currently unable to sign up using email providers other than Gmail. Attempting to register with providers such as Yahoo, Outlook, or custom domain emails results in an error or failed sign-up process. This issue is limiting the user base to only Gmail users, which may hinder the growth of the platform.