Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skeleton loading for crousel #158

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Add skeleton loading for crousel #158

merged 1 commit into from
Oct 14, 2024

Conversation

shubhagarwal1
Copy link
Contributor

@netlify Netlify
Copy link

netlify bot commented Oct 13, 2024

👷 Deploy request for daccotta pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit cc77b2c

AshuKr22
AshuKr22 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@AshuKr22 AshuKr22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@AshuKr22 AshuKr22 merged commit 599d76c into daccotta-org:dev Oct 14, 2024
2 of 3 checks passed
@github-actions GitHub Actions
Copy link

🎉🎉 Thank you for your contribution! Your PR #158 has been merged! 🎉🎉

@AshuKr22 AshuKr22 added bug Something isn't working enhancement New feature or request hacktoberfest issues for hacktoberfest hacktoberfest-accepted gssoc-ext level 1 level 2 and removed level 1 labels Oct 14, 2024
MastanSayyad
MastanSayyad reviewed Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@MastanSayyad MastanSayyad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code formatter is used actual changes are:

image

full review:

  • code formatted removed semicolons that leaded to line changes
  • package.json + package-lock.json affected the lines

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MastanSayyad MastanSayyad MastanSayyad left review comments

@AshuKr22 AshuKr22 AshuKr22 approved these changes

Assignees

@shubhagarwal1 shubhagarwal1

Labels
bug Something isn't working enhancement New feature or request gssoc-ext hacktoberfest issues for hacktoberfest hacktoberfest-accepted level 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skeleton Loading for Header Crousel Card
3 participants
@shubhagarwal1 @MastanSayyad @AshuKr22