Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile responsiveness on Friends page #146

Conversation

PreritAggarwal
Copy link

@PreritAggarwal PreritAggarwal commented Oct 13, 2024

Fix: Mobile Responsiveness on Friends Page

What does this PR do?

  • Fixes the layout issues on the Friends page for mobile screens.
  • Adjusts padding, spacing, and layout to improve user experience.

Why is this needed?

  • Users were experiencing layout breaks and scrolling issues when viewing the Friends page on smaller screens.

Issue Reference:

Copy link

netlify bot commented Oct 13, 2024

👷 Deploy request for daccotta pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 8c85d77

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @PreritAggarwal for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

@shubhagarwal1
Copy link
Contributor

@PreritAggarwal why are raising a PR without assignment of the issue ,the PR you are raising to solve the issue is already raised and the issue was assigned also and the functionality is completed, why do you want to work on the same thing? This behaviour is strictly not allowed in GSSOC open source contribution, this can lead your profile to ban. Please do not repeat this again.

@shubhagarwal1
Copy link
Contributor

@PreritAggarwal why are raising a PR without assignment of the issue ,the PR you are raising to solve the issue is already raised and the issue was assigned also and the functionality is completed, why do you want to work on the same thing? This behaviour is strictly not allowed in GSSOC open source contribution, this can lead your profile to ban. Please do not repeat this again.

@daccotta

@PreritAggarwal
Copy link
Author

I sincerely apologize for raising a PR without being assigned to the issue first. It was an oversight on my part, and I certainly did not intend to cause any disruption or duplicate efforts.
I understand the importance of following proper procedures in open source contributions and will make sure to be more diligent in the future. I truly value the opportunity to contribute to GSSOC, and I will strictly adhere to the guidelines moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Friends page mobile responsiveness and add tooltip to add journel icon in navbar
2 participants