Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp crousel to make it more appealing #106

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

shubhagarwal1
Copy link
Contributor

@shubhagarwal1 shubhagarwal1 commented Oct 9, 2024

fix: #78
Screenshot 2024-10-10 at 1 35 27 AM
@daccotta Please approve my PR

Copy link

netlify bot commented Oct 9, 2024

👷 Deploy request for daccotta pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 7a2b65e

@shubhagarwal1 shubhagarwal1 force-pushed the crouselhead branch 2 times, most recently from 18e3c0c to 24d8a4c Compare October 9, 2024 22:08
@AshuKr22
Copy link
Contributor

AshuKr22 commented Oct 10, 2024

hey @shubhagarwal1 can you also attach a ss of its phone view ? 😅 A recording video would also work fine.
And can those forwards and previous manuall button be more more bigger and with no background. Like Amazon Prime caresoul
Screenshot 2024-10-10 at 2 37 20 PM

@shubhagarwal1
Copy link
Contributor Author

hey @shubhagarwal1 can you also attach a ss of its phone view ? 😅 A recording video would also work fine. And can those forwards and previous manuall button be more more bigger and with no background. Like Amazon Prime caresoul Screenshot 2024-10-10 at 2 37 20 PM

@AshuKr22 okay will make the changes

@AshuKr22
Copy link
Contributor

hey @shubhagarwal1 the ss is not visible.

@shubhagarwal1
Copy link
Contributor Author

hey @shubhagarwal1 the ss is not visible.

i have removed the backgournd from the slide button

Copy link
Contributor

@AshuKr22 AshuKr22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@AshuKr22 AshuKr22 merged commit 68e6601 into daccotta-org:dev Oct 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Carousel to the Header Section
3 participants