Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added direnv support for development testing #16

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

slr71
Copy link
Member

@slr71 slr71 commented Dec 18, 2024

This was originally going to be part of a larger change, but it appears that the larger change isn't necessary at this time. I'm going to submit this for review now simply because I find it to be useful. Hopefully others will as well.

Copy link
Member

@psarando psarando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Although, is there a benefit to the .envrc script vs. using export DISCOENV_... in the .env file and sourcing that (using . ./.env or source ./.env)?

@slr71
Copy link
Member Author

slr71 commented Dec 19, 2024

Thanks for the review!

Although, is there a benefit to the .envrc script vs. using export DISCOENV_... in the .env file and sourcing that (using . ./.env or source ./.env)?

The biggest benefit for me is simply convenience. With direnv installed and .envrc in place, I no longer have to remember to source the .env file every time once I've run direnv allow in that directory. In most cases, this allows me to simply run the service without having to worry about configuration at all.

I'm not entirely sure that I understood the question correctly, so feel free to let me know if I haven't answered it. 😅

@psarando
Copy link
Member

I'm not entirely sure that I understood the question correctly, so feel free to let me know if I haven't answered it. 😅

Yes, thanks, that answers it. I haven't used direnv before, so that does seem convenient 👍

@slr71 slr71 merged commit e4b1bc5 into cyverse-de:main Dec 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants