Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static version numbering & add missing dependency #275

Merged
merged 6 commits into from
Apr 12, 2024
Merged

Static version numbering & add missing dependency #275

merged 6 commits into from
Apr 12, 2024

Conversation

oh2fih
Copy link
Collaborator

@oh2fih oh2fih commented Apr 12, 2024 •
edited
Loading

  • Static version numbering without importing the entire project as build-dependencies in setup.py.
    Ref. 2e7dea0#r140915671
  • Add missing dependency for python-dotenv as main.py has from dotenv import load_dotenv.

oh2fih added 3 commits April 12, 2024 20:14
@oh2fih
Revert buggy solutions
554fab1 
The "switched to static version numbering" caused setup.py to import
the entire project, which was fixed by a hacky workaround of installing
all the dependencies during the build, making them build-dependencies.

This reverts commits:
2e7dea0
3a25395
d55d5b9
@oh2fih
Switch to static version numbering
528180a
@oh2fih
Update version to next target release
3c0ea24
oh2fih referenced this pull request Apr 12, 2024
@P-T-I
switched to static version numbering
2e7dea0
@oh2fih oh2fih changed the title Static version numbering Static version numbering & add missing dependency Apr 12, 2024
@oh2fih
Copy link
Collaborator Author

oh2fih commented Apr 12, 2024

@P-T-I Please review whether this does what you attempted during the releases today, but in a more safe manner. Also notice that the VERSION has already updated for the next target release, 0.3.29.

@P-T-I
Copy link
Member

P-T-I commented Apr 12, 2024

This is way neater! Thanks will merge this right away!

@P-T-I P-T-I merged commit a0c3717 into cve-search:master Apr 12, 2024
3 checks passed
@oh2fih oh2fih deleted the static-version-numbering branch April 12, 2024 19:28
@oh2fih oh2fih mentioned this pull request Apr 12, 2024
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-T-I P-T-I P-T-I approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oh2fih @P-T-I