Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: add dark themes #7

Merged
merged 8 commits into from
Aug 31, 2023

Conversation

felixhahnweilheim
Copy link
Contributor

@felixhahnweilheim felixhahnweilheim commented Aug 26, 2023

This PR adds dark stylesheets (dark.css) to the clean theme. It is meant to work with the upcoming version of the dark mode module.
Related PR: felixhahnweilheim/humhub-dark-mode#9

This PR is only a draft so far and meant as a proof of concept.

The stylesheet dark.css only contains color related CSS. This is achieved by using css-color-extractor: https://github.com/rsanchez/css-color-extractor
Unfortunately this tool does not support CSS variables yet (see rsanchez/css-color-extractor#11). That's why the CSS compiling process is a bit more complex (see the added file build-dark-css.sh).

To do

  • Changelog
  • clean-bordered (dark)
  • clean-contrasted (dark)

Screenshot of clean-base (dark):

Screenshot 2023-08-26 at 21-36-57 Calendar - Family Hub

@marc-farre
Copy link
Member

Thanks a lot @felixhahnweilheim , you've done a really great work!
Tested, the render is very good!

I've only made a very small commit: df48c1b

As soon as Humhub v1.15-beta-2 and Dark mode module v1.0.0-beta4 are released I'll release a new version of this Clean Theme module.
Please let me know when v1.0.0-beta4 is available on the Marketplace.

@marc-farre marc-farre marked this pull request as ready for review August 31, 2023 15:11
@marc-farre marc-farre merged commit f93dc05 into cuzy-app:master Aug 31, 2023
@felixhahnweilheim felixhahnweilheim deleted the add-dark-themes branch August 31, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants