chore: refactor dart call forwarding #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
mrehan27
force-pushed
the
rehan/mbl-660-dart-refactor
branch
from
7e4fd34 to
ad14375
Compare
mrehan27
commented
Nov 26, 2024
| } | ||
|
|
||
| /// Access in-app messaging functionality | ||
| CustomerIOMessagingInAppPlatform get inAppMessaging => _inAppMessaging; | ||
| static CustomerIOMessagingInAppPlatform get inAppMessaging { |
There was a problem hiding this comment.
Updated to match with initial proposal and with pushMessaging
lib/customer_io_method_channel.dart
Outdated
There was a problem hiding this comment.
The file has been moved to lib/data_pipelines/customer_io_method_channel.dart below. But due to significant content changes (because of extension), GitHub shows it as a deleted file.
| import 'customer_io_platform_interface.dart'; | ||
|
|
||
| /// An implementation of [CustomerIOPlatform] that uses method channels. | ||
| class CustomerIOMethodChannel extends CustomerIOPlatform { |
There was a problem hiding this comment.
Updated implementation of lib/customer_io_method_channel.dart using extensions
Shahroz16
reviewed
Nov 27, 2024
|
Discussed on call, and we decided to stick with |
Shahroz16
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of: MBL-660
Changes
inAppMessaginga static property to align with the initial proposalFuture, reflecting asynchronous nature of native calls