chore: initialize native android sdk in flutter #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
mrehan27
commented
Nov 6, 2024
| // Checks if SDK was initialized before, which means lifecycle callbacks are already | ||
| // registered as well | ||
| val isLifecycleCallbacksRegistered = kotlin.runCatching { CustomerIO.instance() }.isSuccess | ||
| val logLevelRawValue = args.getAsTypeOrNull<String>("logLevel") |
There was a problem hiding this comment.
I used hardcoded strings for keys instead because the constants aren't reused outside this function, so I felt they weren't adding much value. That said, I'm open to moving them back to constants if anyone thinks it would improve clarity or maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of MBL-620
Changes