Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update java sample display name #484

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

mrehan27
Copy link
Contributor

@mrehan27 mrehan27 commented Jan 7, 2025

part of: MBL-742

Changes

  • Updated app name on the Login Screen for consistency

Please refer to linked ticket for more details about these changes.

Screenshots

Login Screen

Screenshot_20250107_135840

@mrehan27 mrehan27 requested a review from a team January 7, 2025 09:35
@mrehan27 mrehan27 self-assigned this Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


Copy link

github-actions bot commented Jan 7, 2025

  • java_layout: rehan/mbl-742-app-name (1736242581)

Copy link

github-actions bot commented Jan 7, 2025

Build available to test
Version: rehan-mbl-742-app-name-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

Copy link

github-actions bot commented Jan 7, 2025

  • kotlin_compose: rehan/mbl-742-app-name (1736242575)

Copy link

github-actions bot commented Jan 7, 2025

📏 SDK Binary Size Comparison Report

No changes detected in SDK binary size ✅

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.24%. Comparing base (8b30804) to head (cb9c963).
Report is 34 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main     #484       +/-   ##
=============================================
+ Coverage     41.98%   53.24%   +11.26%     
- Complexity      259      310       +51     
=============================================
  Files            99      100        +1     
  Lines          2320     2663      +343     
  Branches        344      361       +17     
=============================================
+ Hits            974     1418      +444     
+ Misses         1247     1135      -112     
- Partials         99      110       +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mahmoud-elmorabea mahmoud-elmorabea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@mahmoud-elmorabea mahmoud-elmorabea requested a review from a team January 7, 2025 17:16
@Shahroz16 Shahroz16 changed the title chore: update java sample display name fix: update java sample display name Jan 7, 2025
@Shahroz16 Shahroz16 merged commit cc77bbb into main Jan 7, 2025
36 checks passed
@Shahroz16 Shahroz16 deleted the rehan/mbl-742-app-name branch January 7, 2025 18:17
github-actions bot pushed a commit that referenced this pull request Jan 7, 2025
## [4.5.1](4.5.0...4.5.1) (2025-01-07)

### Bug Fixes

* update java sample display name ([#484](#484)) ([cc77bbb](cc77bbb))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants