Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert in app messaging overlay fix #482

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

mahmoud-elmorabea
Copy link
Contributor

Reverts #479 and #480 till the backend fix is applied

@mahmoud-elmorabea mahmoud-elmorabea requested a review from a team January 6, 2025 09:47
@mahmoud-elmorabea mahmoud-elmorabea self-assigned this Jan 6, 2025
@mahmoud-elmorabea mahmoud-elmorabea changed the title Revert in app messaging overlay fix chore: Revert in app messaging overlay fix Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 53.24%. Comparing base (8b30804) to head (b1e18cd).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
...saginginapp/gist/presentation/GistModalActivity.kt 0.00% 13 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main     #482       +/-   ##
=============================================
+ Coverage     41.98%   53.24%   +11.26%     
- Complexity      259      310       +51     
=============================================
  Files            99      100        +1     
  Lines          2320     2663      +343     
  Branches        344      361       +17     
=============================================
+ Hits            974     1418      +444     
+ Misses         1247     1135      -112     
- Partials         99      110       +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 6, 2025

Build available to test
Version: revert-in-app-messaging-overlay-fix-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

Copy link

github-actions bot commented Jan 6, 2025

  • java_layout: revert-in-app-messaging-overlay-fix (1736156920)

Copy link

github-actions bot commented Jan 6, 2025

  • kotlin_compose: revert-in-app-messaging-overlay-fix (1736156912)

Copy link

github-actions bot commented Jan 6, 2025

📏 SDK Binary Size Comparison Report

No changes detected in SDK binary size ✅

@mahmoud-elmorabea mahmoud-elmorabea merged commit 8f644d6 into main Jan 6, 2025
36 checks passed
@mahmoud-elmorabea mahmoud-elmorabea deleted the revert-in-app-messaging-overlay-fix branch January 6, 2025 16:36
mahmoud-elmorabea added a commit that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants