Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: handle the case of empty identifier #476

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

Shahroz16
Copy link
Contributor

closes: MBL-738: Android - Handle device registration when switching from profile with empty string/null identifier.

handles the case, where if profile attributes are added before the identifying the profile, userId was set to empty string.

@Shahroz16 Shahroz16 requested a review from mrehan27 December 15, 2024 12:27
Copy link

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


@Shahroz16 Shahroz16 self-assigned this Dec 15, 2024
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.91%. Comparing base (8b30804) to head (8176723).
Report is 25 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #476      +/-   ##
============================================
+ Coverage     41.98%   51.91%   +9.93%     
- Complexity      259      294      +35     
============================================
  Files            99       96       -3     
  Lines          2320     2585     +265     
  Branches        344      356      +12     
============================================
+ Hits            974     1342     +368     
+ Misses         1247     1134     -113     
- Partials         99      109      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

  • java_layout: mbl-738-empty-identifier (1734265703)

Copy link

Build available to test
Version: mbl-738-empty-identifier-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

Copy link

📏 SDK Binary Size Comparison Report

No changes detected in SDK binary size ✅

Copy link

  • kotlin_compose: mbl-738-empty-identifier (1734265709)

@Shahroz16 Shahroz16 merged commit 9b3efeb into main Dec 17, 2024
35 checks passed
@Shahroz16 Shahroz16 deleted the mbl-738-empty-identifier branch December 17, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants