Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use latest version of setup-sd Github action #460

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

mahmoud-elmorabea
Copy link
Contributor

@mahmoud-elmorabea mahmoud-elmorabea commented Oct 27, 2024

This PR update the SD setup Github action to use the latest version instead of the fork.

Copy link

github-actions bot commented Oct 27, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • java_layout: MBL-627-use-official-setup-sd-action (1730131329)
  • kotlin_compose: MBL-627-use-official-setup-sd-action (1730131328)

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.69%. Comparing base (8b30804) to head (4eae51f).
Report is 13 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #460      +/-   ##
============================================
+ Coverage     41.98%   51.69%   +9.71%     
- Complexity      259      291      +32     
============================================
  Files            99       95       -4     
  Lines          2320     2559     +239     
  Branches        344      350       +6     
============================================
+ Hits            974     1323     +349     
+ Misses         1247     1132     -115     
- Partials         99      104       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Build available to test
Version: MBL-627-use-official-setup-sd-action-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

Copy link

github-actions bot commented Oct 27, 2024

📏 SDK Binary Size Comparison Report

No changes detected in SDK binary size ✅

@mahmoud-elmorabea mahmoud-elmorabea marked this pull request as ready for review October 27, 2024 13:14
@mahmoud-elmorabea mahmoud-elmorabea requested a review from a team October 27, 2024 13:14
Copy link
Contributor

@Shahroz16 Shahroz16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, were we able to verify it's working?

@mahmoud-elmorabea mahmoud-elmorabea merged commit 6bd32ca into main Oct 29, 2024
33 of 35 checks passed
@mahmoud-elmorabea mahmoud-elmorabea deleted the MBL-627-use-official-setup-sd-action branch October 29, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants