Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix installing sd tool needed for deployment #277

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

levibostian
Copy link
Contributor

@levibostian levibostian commented Nov 8, 2023

The iOS SDK experienced a deployment failure on main because of a GH Action that we depend on.

I installed a workaround in the iOS SDK until the GH action gets fixed. This PR applies the same workaround here.

Copy link

github-actions bot commented Nov 8, 2023

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • kotlin_compose: levi/fix-sd-action (1699460212)
  • java_layout: levi/fix-sd-action (1699460226)

@levibostian levibostian requested a review from a team November 8, 2023 16:16
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #277 (2708b75) into main (c494bb0) will increase coverage by 0.67%.
Report is 20 commits behind head on main.
The diff coverage is 44.11%.

@@             Coverage Diff              @@
##               main     #277      +/-   ##
============================================
+ Coverage     49.76%   50.44%   +0.67%     
- Complexity      237      249      +12     
============================================
  Files           108      108              
  Lines          2781     2809      +28     
  Branches        364      363       -1     
============================================
+ Hits           1384     1417      +33     
+ Misses         1282     1275       -7     
- Partials        115      117       +2     
Files Coverage Δ
...customer/messaginginapp/gist/data/model/Message.kt 54.00% <0.00%> (+1.05%) ⬆️
...main/java/io/customer/sdk/queue/QueueRunRequest.kt 98.00% <97.56%> (+7.61%) ⬆️
...stomer/messaginginapp/gist/presentation/GistSdk.kt 13.17% <33.33%> (+13.17%) ⬆️
...ssaginginapp/gist/presentation/GistModalManager.kt 14.70% <0.00%> (+14.70%) ⬆️
...stomer/messaginginapp/gist/data/listeners/Queue.kt 10.57% <30.76%> (+10.57%) ⬆️
...saginginapp/gist/presentation/GistModalActivity.kt 0.00% <0.00%> (ø)
...inginapp/gist/presentation/engine/EngineWebView.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link

github-actions bot commented Nov 8, 2023

Build available to test
Version: levi-fix-sd-action-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

Copy link
Contributor

@Shahroz16 Shahroz16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock PRs but can we make a follow up ticket to get a permanent solution for this?

@@ -74,7 +74,8 @@ jobs:
# CLI to replace strings in files. The CLI recommends using `cargo install` which is slow. This Action is fast because it downloads pre-built binaries.
# If using sd on macos, "brew install" works great. for Linux, this is the recommended way.
- name: Install sd CLI to use later in the workflow
uses: kenji-miyake/setup-sd@v1
# uses: kenji-miyake/setup-sd@v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kenji-miyake/setup-sd@v1 doesn't seem to have many users/stars, can we look for an alternative so we don't bump into issues like these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion to bring up.

The sd CLI is a more stable sed tool. None of us like having to use sed in any of our codebases so I would love to not find an alternative setup-sd action, but find an alternative solution to no longer need sd at all.

I would personally like to move to a semantic-release plugin since updating the version string in our code is part of the deployment process. Plus, by doing string replacement via code instead of CLI, the developer experience for us will be better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levibostian levibostian merged commit 9749894 into main Nov 9, 2023
31 checks passed
@levibostian levibostian deleted the levi/fix-sd-action branch November 9, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants