-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix installing sd tool needed for deployment #277
Conversation
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
Codecov Report
@@ Coverage Diff @@
## main #277 +/- ##
============================================
+ Coverage 49.76% 50.44% +0.67%
- Complexity 237 249 +12
============================================
Files 108 108
Lines 2781 2809 +28
Branches 364 363 -1
============================================
+ Hits 1384 1417 +33
+ Misses 1282 1275 -7
- Partials 115 117 +2
|
Build available to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock PRs but can we make a follow up ticket to get a permanent solution for this?
@@ -74,7 +74,8 @@ jobs: | |||
# CLI to replace strings in files. The CLI recommends using `cargo install` which is slow. This Action is fast because it downloads pre-built binaries. | |||
# If using sd on macos, "brew install" works great. for Linux, this is the recommended way. | |||
- name: Install sd CLI to use later in the workflow | |||
uses: kenji-miyake/setup-sd@v1 | |||
# uses: kenji-miyake/setup-sd@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kenji-miyake/setup-sd@v1
doesn't seem to have many users/stars, can we look for an alternative so we don't bump into issues like these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion to bring up.
The sd
CLI is a more stable sed
tool. None of us like having to use sed
in any of our codebases so I would love to not find an alternative setup-sd
action, but find an alternative solution to no longer need sd
at all.
I would personally like to move to a semantic-release plugin since updating the version string in our code is part of the deployment process. Plus, by doing string replacement via code instead of CLI, the developer experience for us will be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The iOS SDK experienced a deployment failure on
main
because of a GH Action that we depend on.I installed a workaround in the iOS SDK until the GH action gets fixed. This PR applies the same workaround here.