Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML-DSA: update benchmarks pqclean #736

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

franziskuskiefer
Copy link
Member

This updates the pqclean benchmarks to use ml-dsa rather than dilithium.

@franziskuskiefer franziskuskiefer requested a review from a team as a code owner January 9, 2025 10:55
Copy link
Collaborator

@jschneider-bensch jschneider-bensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that makes sense!
The criterion ones are not updated, though. Maybe this is a point where we can decide if we want to keep them? For me, they are still very inconsistent from run to run (large run-to-run diffs in signing, mainly) and for this reason I don't look to them at all, I find. So I would be fine retiring them. But you might get some use out of them still?

@franziskuskiefer
Copy link
Member Author

Good point. I totally forgot about those. I updated them just in case we want to use them again...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants