Added a dummy Kyber implementation and test scaffolding #438
Conversation
|
We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added. |
|
We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added. |
Pull Request Test Coverage Report for Build 7117191938Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
|
We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added. |
|
We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added. |
|
We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added. |
| @@ -6,5 +6,5 @@ printf " ! USE ./mach FOR MORE OPTIONS !\n\n" | |||
|
|
|||
| mkdir build | |||
| cp config/default_config.cmake build/config.cmake | |||
| cmake -B build -G"Ninja Multi-Config" | |||
| cmake -B build -G"Ninja Multi-Config" -DBUILD_LIBCRUX=ON | |||
There was a problem hiding this comment.
Is this used anywhere where we want libcrux on?
I don't think we want libcrux here just yet.
There was a problem hiding this comment.
I just added it there so that it's tested on some of the CI jobs that run this script, but I can remove it.
There was a problem hiding this comment.
If they go through, leave it. But if it makes problems, drop it.
| uint8_t publicKey[KYBER768_PUBLICKEYBYTES]; | ||
| uint8_t secretKey[KYBER768_SECRETKEYBYTES]; | ||
|
|
||
| for (auto kat : kats) { |
There was a problem hiding this comment.
Can we use TEST_P instead to make sure we can run individual tests?
Fixes #437