-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to HACL* ae5d839c2e1fa95055b618cda60aeb1c486c720c #377
Conversation
Pull Request Test Coverage Report for Build 7023476406
💛 - Coveralls |
* merge branch 'main' into pnmadelaine-update * update to HACL* cfd50bcf32693f7b3ad210e39de9371d1c242101 * restore ocaml/lib/Lib_RandomBuffer_System_bindings.ml * update info.txt * fix tests * update rust bindings
* merge branch 'main' into pnmadelaine-update * update to HACL* 45b18730573d3404a57fb63767570cb97897a75f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. I left some comments.
Also: the docs will need to be updated as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks like this is almost good to go.
What's the state of the docs? They seem to still use the old file- and function names.
@pnmadelaine can you update the documentation and look if there's any other comment open? I think this is ready to go otherwise. |
follows hacl-star/hacl-star#789