chore: update release steps to keep crossplane-runtime renovate config up to date #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g up to date Signed-off-by: Jared Watts <[email protected]>
jbw976
commented
Dec 19, 2024
| @@ -28,7 +28,7 @@ examples of each step, assuming release vX.Y.0 is being cut. | |||
| - [ ] Confirm that all security/critical dependency update PRs from Renovate are merged into `main` | |||
| - https://github.com/crossplane/crossplane-runtime/pulls?q=is%3Apr+is%3Aopen+label%3Aautomated | |||
| - [ ] Created the release branch using the [GitHub UI][create-branch]. | |||
| - [ ] (On the **Main** Branch) Created and merged an empty commit with `git commit --allow-empty -s -m "Empty commit after release-X.Y"` | |||
There was a problem hiding this comment.
no more need for an empty commit to crossplane-runtime main because the renovate config PR will serve the same purpose (to move main along ahead of the tag that's in the release branch)
markandersontrocme
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some new instructions to avoid the scenario we just manually fixed in crossplane-runtime with crossplane/crossplane-runtime#797. The Renovate config had fallen behind a couple releases, so we should be able to stay on top of it in future releases with these extra steps.