Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix different loop errors on python 3.12 #62

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Fix different loop errors on python 3.12 #62

merged 2 commits into from
Jun 26, 2024

Conversation

bobh66
Copy link
Collaborator

@bobh66 bobh66 commented Jun 25, 2024 •
edited
Loading

Description of your changes

Moved the loop definition before the server definition so that everything uses the same event loop.
Cleaned up lint configuration warnings.

Fixes crossplane/function-template-python#40

I have:

  • Read and followed Crossplane's contribution process.
    - [ ] Added or updated unit tests for my change.

@bobh66 bobh66 changed the title Loop Fix different loop errors on python 3.12 Jun 25, 2024
@bobh66 bobh66 requested a review from negz June 26, 2024 18:48
negz
negz approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, that's a pretty subtle issue the gRPC upgrade introduced. Nice catch.

@negz negz merged commit d1c067e into crossplane:main Jun 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@negz negz negz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot run function when using Python 3.12
2 participants
@bobh66 @negz